From: Andrew Lunn <andrew@lunn.ch>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: David Miller <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode
Date: Mon, 26 Mar 2018 00:02:37 +0200 [thread overview]
Message-ID: <20180325220237.GA18744@lunn.ch> (raw)
In-Reply-To: <20180325215424.qsfytb5sw5zumzax@pengutronix.de>
On Sun, Mar 25, 2018 at 11:54:24PM +0200, Uwe Kleine-König wrote:
> On Sun, Mar 25, 2018 at 11:43:14PM +0200, Andrew Lunn wrote:
> > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING
> > we override the trigger mode provided in device tree. And the
> > interrupt is actually active low, which is what all the current device
> > tree descriptions use.
> >
> > Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Thanks Andrew for the respin.
Hi Uwe
Sorry for getting your name wrong so many time. I should know better,
'little king' makes sense.
Andrew
next prev parent reply other threads:[~2018-03-25 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-25 21:43 [PATCH v3 net-next 0/2] Fixes to allow mv88e6xxx module to be reloaded Andrew Lunn
2018-03-25 21:43 ` [PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode Andrew Lunn
2018-03-25 21:54 ` Uwe Kleine-König
2018-03-25 22:02 ` Andrew Lunn [this message]
2018-03-25 22:04 ` Uwe Kleine-König
2018-03-25 21:43 ` [PATCH v3 net-next 2/2] net: dsa: mv88e6xxx: Call the common IRQ free code Andrew Lunn
2018-03-26 0:43 ` [PATCH v3 net-next 0/2] Fixes to allow mv88e6xxx module to be reloaded David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180325220237.GA18744@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).