From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH v3 net-next 1/2] net: dsa: mv88e6xxx: Use the DT IRQ trigger mode Date: Mon, 26 Mar 2018 00:02:37 +0200 Message-ID: <20180325220237.GA18744@lunn.ch> References: <1522014195-18671-1-git-send-email-andrew@lunn.ch> <1522014195-18671-2-git-send-email-andrew@lunn.ch> <20180325215424.qsfytb5sw5zumzax@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: David Miller , netdev To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Return-path: Received: from vps0.lunn.ch ([185.16.172.187]:41495 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752094AbeCYWCm (ORCPT ); Sun, 25 Mar 2018 18:02:42 -0400 Content-Disposition: inline In-Reply-To: <20180325215424.qsfytb5sw5zumzax@pengutronix.de> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Mar 25, 2018 at 11:54:24PM +0200, Uwe Kleine-König wrote: > On Sun, Mar 25, 2018 at 11:43:14PM +0200, Andrew Lunn wrote: > > By calling request_threaded_irq() with the flag IRQF_TRIGGER_FALLING > > we override the trigger mode provided in device tree. And the > > interrupt is actually active low, which is what all the current device > > tree descriptions use. > > > > Suggested-by: Uwe Kleine-König > > Signed-off-by: Andrew Lunn > Thanks Andrew for the respin. Hi Uwe Sorry for getting your name wrong so many time. I should know better, 'little king' makes sense. Andrew