From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] XDP router for veth Date: Mon, 26 Mar 2018 10:21:10 -0400 (EDT) Message-ID: <20180326.102110.1068883293248258544.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ebiederm@xmission.com, xemul@openvz.org, netdev@vger.kernel.org, shemminger@osdl.org, edumazet@google.com, dsahern@gmail.com, roopa@cumulusnetworks.com, tom@herbertland.com, alexei.starovoitov@gmail.com, f.fainelli@gmail.com, brouer@redhat.com To: mislam4@kent.edu Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:51128 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752325AbeCZOVO (ORCPT ); Mon, 26 Mar 2018 10:21:14 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: "Md. Islam" Date: Fri, 23 Mar 2018 02:43:16 -0400 > +#ifdef CONFIG_XDP_ROUTER > + //if IP forwarding is enabled on the receiver, create xdp_buff > + //from skb and call xdp_router_forward() Never use C++ comments, only use C style. > + if(is_forwarding_enabled(rcv)){ There must be a space between 'if' and the openning parenthesis. You need to also have a space before the openning curly braces. In fact this entire patch is full of coding style issues, please run your changes through checkpatch.pl before resubmitting.