From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 0/2] sh_eth: unify the SoC feature checks Date: Mon, 26 Mar 2018 12:34:47 -0400 (EDT) Message-ID: <20180326.123447.1350791578528691423.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org To: sergei.shtylyov@cogentembedded.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:52982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbeCZQet (ORCPT ); Mon, 26 Mar 2018 12:34:49 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Sergei Shtylyov Date: Sat, 24 Mar 2018 23:04:53 +0300 > Here's a set of 5 patches against DaveM's 'net-next.git' repo. > > The Ether driver sometimes uses the bit fields in 'struct sh_eth_cpu_data' > to check which Ether registers exist in a certain SoC and sometimes it uses > sh_eth_is_{gether|rz_fast_ether}() which basically compares 2 pointers (1 of > them being constant) -- the latter is definitely not a strongest feature of > the RISC CPUs (be it SH or ARM), so I decided to get rid of this type of > the feature checks in favour of the bit fields (I've also made use of a > 32-bit value and method pointer where appropriate)... Series applied with patch #4 subject fixed up. Thank you.