From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net] team: move dev_mc_sync after master_upper_dev_link in team_port_add Date: Mon, 26 Mar 2018 16:38:11 +0200 Message-ID: <20180326143811.GJ1891@nanopsycho> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: network dev , davem@davemloft.net To: Xin Long Return-path: Received: from mail-wm0-f47.google.com ([74.125.82.47]:50429 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbeCZOiN (ORCPT ); Mon, 26 Mar 2018 10:38:13 -0400 Received: by mail-wm0-f47.google.com with SMTP id i75so15846072wmf.0 for ; Mon, 26 Mar 2018 07:38:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Sun, Mar 25, 2018 at 07:25:06PM CEST, lucien.xin@gmail.com wrote: >The same fix as in 'bonding: move dev_mc_sync after master_upper_dev_link >in bond_enslave' is needed for team driver. > >The panic can be reproduced easily: > > ip link add team1 type team > ip link set team1 up > ip link add link team1 vlan1 type vlan id 80 > ip link set vlan1 master team1 > >Fixes: cb41c997d444 ("team: team should sync the port's uc/mc addrs when add a port") >Signed-off-by: Xin Long Acked-by: Jiri Pirko