From: Leon Romanovsky <leon@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: netdev <netdev@vger.kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next 2/2] rdma: Print net device name and index for RDMA device
Date: Mon, 26 Mar 2018 19:57:50 +0300 [thread overview]
Message-ID: <20180326165750.GJ1877@mtr-leonro.local> (raw)
In-Reply-To: <5f7e480c-dfa5-f246-cb3a-0264128640cf@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1233 bytes --]
On Mon, Mar 26, 2018 at 09:44:32AM -0600, David Ahern wrote:
> On 3/26/18 9:09 AM, Leon Romanovsky wrote:
> > On Mon, Mar 26, 2018 at 08:06:52AM -0600, David Ahern wrote:
> >> On 3/26/18 2:28 AM, Leon Romanovsky wrote:
> >>> diff --git a/rdma/include/uapi/rdma/rdma_netlink.h b/rdma/include/uapi/rdma/rdma_netlink.h
> >>> index 9446a721..45474f13 100644
> >>> --- a/rdma/include/uapi/rdma/rdma_netlink.h
> >>> +++ b/rdma/include/uapi/rdma/rdma_netlink.h
> >>> @@ -388,6 +388,10 @@ enum rdma_nldev_attr {
> >>> RDMA_NLDEV_ATTR_RES_LOCAL_DMA_LKEY, /* u32 */
> >>> RDMA_NLDEV_ATTR_RES_UNSAFE_GLOBAL_RKEY, /* u32 */
> >>>
> >>> + /* Netdev information for relevant protocols, like RoCE and iWARP */
> >>> + RDMA_NLDEV_ATTR_NDEV_INDEX, /* u32 */
> >>> + RDMA_NLDEV_ATTR_NDEV_NAME, /* string */
> >>> +
> >>> RDMA_NLDEV_ATTR_MAX
> >>> };
> >>> #endif /* _RDMA_NETLINK_H */
> >>
> >> Why wasn't the above included in patch 1 as part of the header file update?
> >>
> >>
> >
> > Kernel part is not accepted yet, this is why I separated them.
> >
> Please don't mix patches in a set like this. The entire set should be
> consistent -- either all of them are in the kernel or all of them are
> waiting to be committed.
Ok, I'll do.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-26 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 8:28 [PATCH iproute2-next 0/2] Print netdevice names and indexes for relevant RDMA devices Leon Romanovsky
2018-03-26 8:28 ` [PATCH iproute2-next 1/2] rdma: Update RDMA header file Leon Romanovsky
2018-03-26 8:28 ` [PATCH iproute2-next 2/2] rdma: Print net device name and index for RDMA device Leon Romanovsky
2018-03-26 14:06 ` David Ahern
2018-03-26 15:09 ` Leon Romanovsky
2018-03-26 15:44 ` David Ahern
2018-03-26 16:57 ` Leon Romanovsky [this message]
2018-03-26 15:17 ` Steve Wise
2018-03-26 17:00 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180326165750.GJ1877@mtr-leonro.local \
--to=leon@kernel.org \
--cc=dsahern@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).