netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, virtualization@lists.linux-foundation.org,
	kvm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH V2 0/8] Packed ring for vhost
Date: Mon, 26 Mar 2018 15:01:30 -0400	[thread overview]
Message-ID: <20180326190130.GE6928@char.us.oracle.com> (raw)
In-Reply-To: <1522035533-11786-1-git-send-email-jasowang@redhat.com>

On Mon, Mar 26, 2018 at 11:38:45AM +0800, Jason Wang wrote:
> Hi all:
> 
> This RFC implement packed ring layout. The code were tested with pmd
> implement by Jens at
> http://dpdk.org/ml/archives/dev/2018-January/089417.html. Minor change
> was needed for pmd codes to kick virtqueue since it assumes a busy
> polling backend.
> 
> Test were done between localhost and guest. Testpmd (rxonly) in guest
> reports 2.4Mpps. Testpmd (txonly) repots about 2.1Mpps.

And how does it compare to older ring layout?

> 
> Notes: The event suppression /indirect descriptor support is complied
>        test only because of lacked driver support.
> 
> Changes from V1:
> 
> - Refactor vhost used elem code to avoid open coding on used elem
> - Event suppression support (compile test only).
> - Indirect descriptor support (compile test only).
> - Zerocopy support.
> - vIOMMU support.
> - SCSI/VSOCK support (compile test only).
> - Fix several bugs
> 
> For simplicity, I don't implement batching or other optimizations.
> 
> Please review.
> 
> Thanks
> 
> Jason Wang (8):
>   vhost: move get_rx_bufs to vhost.c
>   vhost: hide used ring layout from device
>   vhost: do not use vring_used_elem
>   vhost_net: do not explicitly manipulate vhost_used_elem
>   vhost: vhost_put_user() can accept metadata type
>   virtio: introduce packed ring defines
>   vhost: packed ring support
>   vhost: event suppression for packed ring
> 
>  drivers/vhost/net.c                | 138 ++-----
>  drivers/vhost/scsi.c               |  62 +--
>  drivers/vhost/vhost.c              | 818 ++++++++++++++++++++++++++++++++++---
>  drivers/vhost/vhost.h              |  46 ++-
>  drivers/vhost/vsock.c              |  42 +-
>  include/uapi/linux/virtio_config.h |   9 +
>  include/uapi/linux/virtio_ring.h   |  32 ++
>  7 files changed, 921 insertions(+), 226 deletions(-)
> 
> -- 
> 2.7.4
> 

  parent reply	other threads:[~2018-03-26 19:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26  3:38 [RFC PATCH V2 0/8] Packed ring for vhost Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 1/8] vhost: move get_rx_bufs to vhost.c Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 2/8] vhost: hide used ring layout from device Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 3/8] vhost: do not use vring_used_elem Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 4/8] vhost_net: do not explicitly manipulate vhost_used_elem Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 5/8] vhost: vhost_put_user() can accept metadata type Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 6/8] virtio: introduce packed ring defines Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 7/8] vhost: packed ring support Jason Wang
2018-03-26  3:38 ` [RFC PATCH V2 8/8] vhost: event suppression for packed ring Jason Wang
2018-03-30  2:05   ` Tiwei Bie
2018-03-30  2:46     ` Jason Wang
2018-03-26  3:44 ` [RFC PATCH V2 0/8] Packed ring for vhost Jason Wang
2018-03-26 19:01 ` Konrad Rzeszutek Wilk [this message]
2018-03-27  3:33   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326190130.GE6928@char.us.oracle.com \
    --to=konrad.wilk@oracle.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).