netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Steve Wise <swise@opengridcomputing.com>
Cc: David Ahern <dsahern@gmail.com>,
	leon@kernel.org, stephen@networkplumber.org,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information
Date: Mon, 26 Mar 2018 15:15:05 -0600	[thread overview]
Message-ID: <20180326211505.GF15554@ziepe.ca> (raw)
In-Reply-To: <0443b8e0-17ff-1e62-51ba-ba1fa0e0d529@opengridcomputing.com>

On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote:
> 
> 
> On 3/26/2018 9:17 AM, David Ahern wrote:
> > On 2/27/18 9:07 AM, Steve Wise wrote:
> >> diff --git a/rdma/rdma.h b/rdma/rdma.h
> >> index 5809f70..e55205b 100644
> >> +++ b/rdma/rdma.h
> >> @@ -18,10 +18,12 @@
> >>  #include <libmnl/libmnl.h>
> >>  #include <rdma/rdma_netlink.h>
> >>  #include <time.h>
> >> +#include <net/if_arp.h>
> >>  
> >>  #include "list.h"
> >>  #include "utils.h"
> >>  #include "json_writer.h"
> >> +#include <rdma/rdma_cma.h>
> >>  
> > did you forget to add rdma_cma.h? I don't see that file in my repo.
> 
> It is provided by the rdma-core package, upon which rdma tool now
> depends for the rdma_port_space enum.

It is a kernel bug that enum is not in an include/uapi/rdma header

Fix it there and don't try to use rdma-core headers to get kernel ABI.

Jason

  parent reply	other threads:[~2018-03-26 21:15 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-02 19:55 [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking Steve Wise
2018-02-27 16:06 ` [PATCH v2 iproute2-next 1/6] rdma: update rdma_netlink.h Steve Wise
2018-02-27 16:07 ` [PATCH v2 iproute2-next 2/6] rdma: initialize the rd struct Steve Wise
2018-03-13 18:11   ` Leon Romanovsky
2018-02-27 16:07 ` [PATCH v2 iproute2-next 3/6] rdma: Add CM_ID resource tracking information Steve Wise
2018-03-13 18:07   ` Leon Romanovsky
2018-03-13 19:44     ` Steve Wise
2018-03-26 14:17   ` David Ahern
2018-03-26 14:30     ` Steve Wise
2018-03-26 14:44       ` David Ahern
2018-03-26 14:55         ` Steve Wise
2018-03-26 15:08           ` Leon Romanovsky
2018-03-26 15:24             ` Steve Wise
2018-03-26 17:06               ` Leon Romanovsky
2018-03-26 17:13                 ` Steve Wise
2018-03-26 17:27                   ` Leon Romanovsky
2018-03-26 21:15       ` Jason Gunthorpe [this message]
2018-03-26 21:34         ` Steve Wise
2018-03-26 22:30           ` Jason Gunthorpe
2018-03-27  3:21             ` Leon Romanovsky
2018-03-27 14:44               ` Jason Gunthorpe
2018-03-27 15:15                 ` Leon Romanovsky
2018-03-27 15:23                   ` Jason Gunthorpe
2018-03-27 15:45                     ` Steve Wise
2018-03-27 16:01                       ` Leon Romanovsky
2018-03-27 16:20                         ` Steve Wise
2018-03-27 16:30                           ` Leon Romanovsky
2018-03-27 16:38                             ` Steve Wise
2018-03-26 15:40   ` David Ahern
2018-03-26 19:55     ` Steve Wise
2018-02-27 16:07 ` [PATCH v2 iproute2-next 4/6] rdma: Add CQ " Steve Wise
2018-03-13 19:05   ` Leon Romanovsky
2018-02-27 16:07 ` [PATCH v2 iproute2-next 5/6] rdma: Add MR " Steve Wise
2018-03-13 19:06   ` Leon Romanovsky
2018-02-27 16:07 ` [PATCH v2 iproute2-next 6/6] rdma: Add PD " Steve Wise
2018-03-13 19:07   ` Leon Romanovsky
2018-03-12 15:16 ` [PATCH v2 iproute2-next 0/6] cm_id, cq, mr, and pd resource tracking Steve Wise
2018-03-12 17:53   ` David Ahern
2018-03-12 18:43     ` Steve Wise
2018-03-13  8:32     ` Leon Romanovsky
2018-03-13 20:45       ` David Ahern
2018-03-13 20:58         ` Doug Ledford
2018-03-16 16:18           ` David Ahern
2018-03-20 17:21             ` Doug Ledford
2018-03-21 16:59               ` David Ahern
2018-03-22 20:20                 ` Steve Wise
2018-03-22 20:26                   ` David Ahern
2018-03-13 21:13         ` Jason Gunthorpe
2018-03-15  3:14           ` David Ahern
2018-03-15  3:29             ` Jason Gunthorpe
2018-03-16 16:08               ` David Ahern
2018-03-16 16:23                 ` Leon Romanovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180326211505.GF15554@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=dsahern@gmail.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).