From mboxrd@z Thu Jan  1 00:00:00 1970
From: Francois Romieu <romieu@fr.zoreil.com>
Subject: Re: [PATCH net] r8169: fix setting driver_data after register_netdev
Date: Tue, 27 Mar 2018 00:18:40 +0200
Message-ID: <20180326221840.GA32458@electric-eye.fr.zoreil.com>
References: <4fbb6b47-d4aa-2b21-34ba-383e085ed236@gmail.com>
 <20180325230700.GA1735@electric-eye.fr.zoreil.com>
 <20180325232439.GD19365@lunn.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
        Realtek linux nic maintainers <nic_swsd@realtek.com>,
        David Miller <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Return-path: <netdev-owner@vger.kernel.org>
Received: from violet.fr.zoreil.com ([92.243.8.30]:37979 "EHLO
        violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752439AbeCZWYC (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 26 Mar 2018 18:24:02 -0400
Content-Disposition: inline
In-Reply-To: <20180325232439.GD19365@lunn.ch>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Andrew Lunn <andrew@lunn.ch> :
[...]
> How about rtl8169_get_wol() and rtl8169_set_wol(). And
> rtl8169_get_ethtool_stats().

rtl8169_get_wol does not depend on dev->driver_data. Neither does
rtl8169_set_wol() nor rtl8169_get_ethtool_stats().

> Basically anything which makes use of run time power management
> could be invoked as soon as parts of register_netdev() have been
> called.

Ok, it can crash through rtl_open and check_link_status.

If rtl_open can be called that early, rtl_init_one::rtl8168_driver_start()
may also be executed a bit late.

-- 
Ueimor