From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2 net] r8169: fix setting driver_data after register_netdev Date: Tue, 27 Mar 2018 10:56:42 -0400 (EDT) Message-ID: <20180327.105642.798955649175788501.davem@davemloft.net> References: <2e728314-2f34-1e51-7a4a-ae227eb2a2c6@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: nic_swsd@realtek.com, netdev@vger.kernel.org To: hkallweit1@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:41016 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751195AbeC0O4o (ORCPT ); Tue, 27 Mar 2018 10:56:44 -0400 In-Reply-To: <2e728314-2f34-1e51-7a4a-ae227eb2a2c6@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Heiner Kallweit Date: Mon, 26 Mar 2018 19:19:30 +0200 > pci_set_drvdata() is called only after registering the net_device, > therefore we could run into a NPE if one of the functions using > driver_data is called before it's set. > > Fix this by calling pci_set_drvdata() before registering the > net_device. > > This fix is a candidate for stable. As far as I can see the > bug has been there in kernel version 3.2 already, therefore > I can't provide a reference which commit is fixed by it. > > The fix may need small adjustments per kernel version because > due to other changes the label which is jumped to if > register_netdev() fails has changed over time. > > Reported-by: David Miller > Signed-off-by: Heiner Kallweit > --- > v2: > - rebased based on net instead of net-next Applied and queued up for -stable, thanks.