Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: cdillaba@mojatatu.com
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
	xiyou.wangcong@gmail.com, jiri@resnulli.us
Subject: Re: [PATCH net 1/1] net sched actions: fix dumping which requires several messages to user space
Date: Tue, 27 Mar 2018 10:59:45 -0400 (EDT)	[thread overview]
Message-ID: <20180327.105945.563897120983885303.davem@davemloft.net> (raw)
In-Reply-To: <1522090712-9154-1-git-send-email-cdillaba@mojatatu.com>

From: Craig Dillabaugh <cdillaba@mojatatu.com>
Date: Mon, 26 Mar 2018 14:58:32 -0400

>     Fixes a bug in the tcf_dump_walker function that can cause some actions
>     to not be reported when dumping a large number of actions. This issue
>     became more aggrevated when cookies feature was added. In particular
>     this issue is manifest when large cookie values are assigned to the
>     actions and when enough actions are created that the resulting table
>     must be dumped in multiple batches.
> 
>     The number of actions returned in each batch is limited by the total
>     number of actions and the memory buffer size.  With small cookies
>     the numeric limit is reached before the buffer size limit, which avoids
>     the code path triggering this bug. When large cookies are used buffer
>     fills before the numeric limit, and the erroneous code path is hit.
> 
>     For example after creating 32 csum actions with the cookie
>     aaaabbbbccccdddd
 ...
>     Note that the action with index 27 is omitted from the report.
> 
> Fixes: 4b3550ef530c ("[NET_SCHED]: Use nla_nest_start/nla_nest_end")"
> Signed-off-by: Craig Dillabaugh <cdillaba@mojatatu.com>

Applied and queued up for -stable.

      parent reply	other threads:[~2018-03-27 14:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-26 18:58 [PATCH net 1/1] net sched actions: fix dumping which requires several messages to user space Craig Dillabaugh
2018-03-27 11:26 ` Jamal Hadi Salim
2018-03-27 14:59 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180327.105945.563897120983885303.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=cdillaba@mojatatu.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=kernel@mojatatu.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox