From: David Miller <davem@davemloft.net>
To: ecree@solarflare.com
Cc: linux-net-drivers@solarflare.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 0/6] sfc: rework locking around filter management
Date: Tue, 27 Mar 2018 13:34:15 -0400 (EDT) [thread overview]
Message-ID: <20180327.133415.1695812033939717097.davem@davemloft.net> (raw)
In-Reply-To: <7a932be7-0335-a7f3-4fb4-408ccb191737@solarflare.com>
From: Edward Cree <ecree@solarflare.com>
Date: Tue, 27 Mar 2018 17:40:11 +0100
> The use of a spinlock to protect filter state combined with the need for a
> sleeping operation (MCDI) to apply that state to the NIC (on EF10) led to
> unfixable race conditions, around the handling of filter restoration after
> an MC reboot.
> So, this patch series removes the requirement to be able to modify the SW
> filter table from atomic context, by using a workqueue to request
> asynchronous filter operations (which are needed for ARFS). Then, the
> filter table locks are changed to mutexes, replacing the dance of spinlocks
> and 'busy' flags. Also, a mutex is added to protect the RSS context state,
> since otherwise a similar race is possible around restoring that after an
> MC reboot. While we're at it, fix a couple of other related bugs.
Series applied, thank you.
prev parent reply other threads:[~2018-03-27 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 16:40 [PATCH net-next 0/6] sfc: rework locking around filter management Edward Cree
2018-03-27 16:41 ` [PATCH net-next 1/6] sfc: replace asynchronous filter operations Edward Cree
2018-03-27 16:42 ` [PATCH net-next 2/6] sfc: give ef10 its own rwsem in the filter table instead of filter_lock Edward Cree
2018-03-27 16:42 ` [PATCH net-next 3/6] sfc: use a semaphore to lock farch filters too Edward Cree
2018-03-27 16:44 ` [PATCH net-next 4/6] sfc: return a better error if filter insertion collides with MC reboot Edward Cree
2018-03-27 16:44 ` [PATCH net-next 5/6] sfc: protect list of RSS contexts under a mutex Edward Cree
2018-03-27 16:44 ` [PATCH net-next 6/6] sfc: fix flow type handling for RSS filters Edward Cree
2018-03-27 17:34 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327.133415.1695812033939717097.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ecree@solarflare.com \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).