From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [patch iproute2 rfc 1/2] devlink: introduce support for showing
 port flavours
Date: Tue, 27 Mar 2018 08:28:54 -0700
Message-ID: <20180327082854.57e7e865@xeon-e3>
References: <20180322233550.GE6544@lunn.ch>
        <20180323063558.11718-1-jiri@resnulli.us>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, davem@davemloft.net, idosch@mellanox.com,
        jakub.kicinski@netronome.com, mlxsw@mellanox.com, andrew@lunn.ch,
        vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
        michael.chan@broadcom.com, ganeshgr@chelsio.com,
        saeedm@mellanox.com, simon.horman@netronome.com,
        pieter.jansenvanvuuren@netronome.com, john.hurley@netronome.com,
        dirk.vandermerwe@netronome.com, alexander.h.duyck@intel.com,
        ogerlitz@mellanox.com, dsahern@gmail.com, vijaya.guvva@cavium.com,
        satananda.burla@cavium.com, raghu.vatsavayi@cavium.com,
        felix.manlunas@cavium.com, gospo@broadcom.com,
        sathya.perla@broadcom.com, vasundhara-v.volam@broadcom.com,
        tariqt@mellanox.com, eranbe@mellanox.com,
        jeffrey.t.kirsher@intel.com
To: Jiri Pirko <jiri@resnulli.us>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f68.google.com ([209.85.160.68]:36961 "EHLO
        mail-pl0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752568AbeC0P26 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 27 Mar 2018 11:28:58 -0400
Received: by mail-pl0-f68.google.com with SMTP id v7-v6so566361plo.4
        for <netdev@vger.kernel.org>; Tue, 27 Mar 2018 08:28:58 -0700 (PDT)
In-Reply-To: <20180323063558.11718-1-jiri@resnulli.us>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, 23 Mar 2018 07:35:57 +0100
Jiri Pirko <jiri@resnulli.us> wrote:

> +static const char *port_flavour_name(uint16_t flavour)
> +{
> +	switch (flavour) {
> +	case DEVLINK_PORT_FLAVOUR_PHYSICAL: return "physical";
> +	case DEVLINK_PORT_FLAVOUR_PF_REP: return "pf_rep";
> +	case DEVLINK_PORT_FLAVOUR_VF_REP: return "vf_rep";
> +	default: return "<unknown flavour>";
> +	}
> +}
> +

need to break lines even in switch statement.