From: Stephen Hemminger <stephen@networkplumber.org>
To: Alexander Zubkov <green@msu.ru>
Cc: Serhey Popovych <serhe.popovych@gmail.com>,
Luca Boccassi <bluca@debian.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes"
Date: Tue, 27 Mar 2018 09:01:35 -0700 [thread overview]
Message-ID: <20180327090135.7d60b796@xeon-e3> (raw)
In-Reply-To: <2ee0179a-79c8-8504-afe1-6310ed4e858b@msu.ru>
On Wed, 14 Mar 2018 21:26:40 +0100
Alexander Zubkov <green@msu.ru> wrote:
> Hello,
>
> For example, it can be fixed in such way (patch is below):
> - split handling of default and all/any
> - set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag for default
> - and AF_UNSPEC for all/any
> In this case "ip route show default" shows only default route and "ip
> route show all" shows all routes. And both also work when family (-4 or
> -6) is specified.
> Serhey, does it goes in line with what you wanted to achieve? Because I
> do not know - may be there are reasons why all/any should be provided
> with specific family. If you think this solution is suitable, I'll do
> some additional tests and package the patch in a proper way for this
> mailing list.
> And I'm unsure if check for AF_DECnet and AF_MPLS should be kept in both
> branches. May be someone have some additional thoughts on that?
>
I applied this to master.
We can work on the other cases after that.
next prev parent reply other threads:[~2018-03-27 16:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 21:03 [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Stephen Hemminger
2018-03-12 21:37 ` Luca Boccassi
2018-03-13 8:46 ` Alexander Zubkov
2018-03-13 11:05 ` Alexander Zubkov
2018-03-13 12:02 ` Luca Boccassi
2018-03-13 20:12 ` Alexander Zubkov
2018-03-13 20:15 ` Luca Boccassi
2018-03-14 8:59 ` Alexander Zubkov
2018-03-14 20:26 ` Alexander Zubkov
2018-03-18 16:50 ` [PATCH iproute2] treat "default" and "all"/"any" addresses differenty Alexander Zubkov
2018-03-18 17:02 ` Alexander Zubkov
2018-03-27 16:01 ` Stephen Hemminger [this message]
2018-03-27 16:29 ` [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Alexander Zubkov
2018-03-27 17:00 ` Stephen Hemminger
2018-03-27 17:33 ` Alexander Zubkov
2018-03-27 17:58 ` Stephen Hemminger
2018-03-27 23:57 ` [PATCH iproute] arrange prefix parsing code after redundant patches Alexander Zubkov
2018-03-29 15:44 ` Stephen Hemminger
2018-03-13 20:19 ` [PATCH iproute2] treat "default" and "all"/"any" parameters differenty Alexander Zubkov
2018-03-13 21:45 ` Luca Boccassi
2018-03-16 20:37 ` Stephen Hemminger
2018-03-16 20:59 ` Alexander Zubkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327090135.7d60b796@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bluca@debian.org \
--cc=green@msu.ru \
--cc=netdev@vger.kernel.org \
--cc=serhe.popovych@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).