From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH iproute2] Revert "iproute: "list/flush/save default" selected all of the routes" Date: Tue, 27 Mar 2018 10:00:14 -0700 Message-ID: <20180327100014.466e3f8b@xeon-e3> References: <20180312210301.12757-1-stephen@networkplumber.org> <1520890670.31389.1.camel@debian.org> <3677951520930804@web6j.yandex.ru> <1084221520939138@web32g.yandex.ru> <1520942521.12414.1.camel@debian.org> <3ebb9805-fb69-c67d-6222-c6d1d344f4ec@msu.ru> <135881521017992@web3o.yandex.ru> <2ee0179a-79c8-8504-afe1-6310ed4e858b@msu.ru> <20180327090135.7d60b796@xeon-e3> <606551522168171@web35g.yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Serhey Popovych , Luca Boccassi , "netdev@vger.kernel.org" To: Alexander Zubkov Return-path: Received: from mail-pg0-f49.google.com ([74.125.83.49]:33543 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754895AbeC0RAR (ORCPT ); Tue, 27 Mar 2018 13:00:17 -0400 Received: by mail-pg0-f49.google.com with SMTP id i194so4579254pgd.0 for ; Tue, 27 Mar 2018 10:00:17 -0700 (PDT) In-Reply-To: <606551522168171@web35g.yandex.ru> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 27 Mar 2018 18:29:31 +0200 Alexander Zubkov wrote: > Hi Stephen, >=20 > Looks like the new patch was applied after the revert of original patch a= nd fix patch for 4.15 branch. Which is not correct and I did not test it. T= his is how patches were designed: > 1) your revert patch - rolls back 4.15 branch to old behaviour by reverti= ng the original patch > 2) my patch for 4.15 - fixes problem is 4.15 branch, it does not require = revert patch, it is an alternative solution for the problem, it is designed= solely for version 4.15 > 3) my patch for master - fixes problem, it requires neither revert patch = nor my patch for 4.15, it is standalone patch designed to do things right i= n master branch >=20 > 27.03.2018, 18:01, "Stephen Hemminger" : > > On Wed, 14 Mar 2018 21:26:40 +0100 > > Alexander Zubkov wrote: > > =20 > >> =C2=A0Hello, > >> > >> =C2=A0For example, it can be fixed in such way (patch is below): > >> =C2=A0- split handling of default and all/any > >> =C2=A0- set needed attributes in get_addr: PREFIXLEN_SPECIFIED flag fo= r default > >> =C2=A0- and AF_UNSPEC for all/any > >> =C2=A0In this case "ip route show default" shows only default route an= d "ip > >> =C2=A0route show all" shows all routes. And both also work when family= (-4 or > >> =C2=A0-6) is specified. > >> =C2=A0Serhey, does it goes in line with what you wanted to achieve? Be= cause I > >> =C2=A0do not know - may be there are reasons why all/any should be pro= vided > >> =C2=A0with specific family. If you think this solution is suitable, I'= ll do > >> =C2=A0some additional tests and package the patch in a proper way for = this > >> =C2=A0mailing list. > >> =C2=A0And I'm unsure if check for AF_DECnet and AF_MPLS should be kept= in both > >> =C2=A0branches. May be someone have some additional thoughts on that? = =20 > > > > I applied this to master. > > > > We can work on the other cases after that. =20 Please send the update back to what works.