From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org
Subject: Re: [iproute PATCH 2/3] ss: Put filter DB parsing into a separate function
Date: Tue, 27 Mar 2018 11:46:01 -0700 [thread overview]
Message-ID: <20180327114601.62112467@xeon-e3> (raw)
In-Reply-To: <20180324181811.22615-3-phil@nwl.cc>
On Sat, 24 Mar 2018 19:18:10 +0100
Phil Sutter <phil@nwl.cc> wrote:
> +#define ENTRY(name, ...) { #name, { __VA_ARGS__, MAX_DB }}
> + ENTRY(all, UDP_DB, DCCP_DB, TCP_DB, RAW_DB, \
> + UNIX_ST_DB, UNIX_DG_DB, UNIX_SQ_DB, \
> + PACKET_R_DB, PACKET_DG_DB, NETLINK_DB, \
> + SCTP_DB, VSOCK_ST_DB, VSOCK_DG_DB),
Checkpatch complains that line continuations are not necessary here;
and it is right. Macro usage can cross lines.
next prev parent reply other threads:[~2018-03-27 18:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-24 18:18 [iproute PATCH 0/3] ss: Allow excluding a socket table from being queried Phil Sutter
2018-03-24 18:18 ` [iproute PATCH 1/3] " Phil Sutter
2018-03-24 18:18 ` [iproute PATCH 2/3] ss: Put filter DB parsing into a separate function Phil Sutter
2018-03-27 18:46 ` Stephen Hemminger [this message]
2018-03-27 23:39 ` Phil Sutter
2018-03-24 18:18 ` [iproute PATCH 3/3] ss: Drop filter_default_dbs() Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327114601.62112467@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox