From: Florian Westphal <fw@strlen.de>
To: syzbot <syzbot+a46d6abf9d56b1365a72@syzkaller.appspotmail.com>
Cc: netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com, ja@ssi.bg
Subject: Re: possible deadlock in rtnl_lock (5)
Date: Tue, 27 Mar 2018 13:50:01 +0200 [thread overview]
Message-ID: <20180327115001.GC26275@breakpoint.cc> (raw)
In-Reply-To: <000000000000f7826f0568630354@google.com>
syzbot <syzbot+a46d6abf9d56b1365a72@syzkaller.appspotmail.com> wrote:
[ cc Julian and trimming cc list ]
> syzkaller688027/4497 is trying to acquire lock:
> (rtnl_mutex){+.+.}, at: [<00000000bb14d7fb>] rtnl_lock+0x17/0x20
> net/core/rtnetlink.c:74
> but task is already holding lock:
> IPVS: stopping backup sync thread 4495 ...
> (rtnl_mutex){+.+.}, at: [<00000000bb14d7fb>] rtnl_lock+0x17/0x20
> net/core/rtnetlink.c:74
>
> other info that might help us debug this:
> Possible unsafe locking scenario:
>
> CPU0
> ----
> lock(rtnl_mutex);
> lock(rtnl_mutex);
>
> *** DEADLOCK ***
>
> May be due to missing lock nesting notation
Looks like this is real, commit e0b26cc997d57305b4097711e12e13992580ae34
("ipvs: call rtnl_lock early") added rtnl_lock when starting sync thread
but socket close invokes rtnl_lock too:
> stack backtrace:
> rtnl_lock+0x17/0x20 net/core/rtnetlink.c:74
> ip_mc_drop_socket+0x88/0x230 net/ipv4/igmp.c:2643
> inet_release+0x4e/0x1c0 net/ipv4/af_inet.c:413
> sock_release+0x8d/0x1e0 net/socket.c:595
> start_sync_thread+0x2213/0x2b70 net/netfilter/ipvs/ip_vs_sync.c:1924
> do_ip_vs_set_ctl+0x1139/0x1cc0 net/netfilter/ipvs/ip_vs_ctl.c:2389
next prev parent reply other threads:[~2018-03-27 11:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 11:16 possible deadlock in rtnl_lock (5) syzbot
2018-03-27 11:50 ` Florian Westphal [this message]
2018-03-27 19:52 ` Julian Anastasov
2018-03-28 5:56 ` Dmitry Vyukov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180327115001.GC26275@breakpoint.cc \
--to=fw@strlen.de \
--cc=ja@ssi.bg \
--cc=netdev@vger.kernel.org \
--cc=syzbot+a46d6abf9d56b1365a72@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).