From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v3 iproute2 1/1] tc: fix conversion types when printing actions unsigned values Date: Tue, 27 Mar 2018 14:56:59 -0700 Message-ID: <20180327145659.26fbce4a@xeon-e3> References: <1521493541-31340-1-git-send-email-mrv@mojatatu.com> <20180327090234.5d457806@xeon-e3> <85tvt1i4q6.fsf@mojatatu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us To: Roman Mashak Return-path: Received: from mail-pg0-f52.google.com ([74.125.83.52]:41509 "EHLO mail-pg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751020AbeC0V5C (ORCPT ); Tue, 27 Mar 2018 17:57:02 -0400 Received: by mail-pg0-f52.google.com with SMTP id t10so155213pgv.8 for ; Tue, 27 Mar 2018 14:57:02 -0700 (PDT) In-Reply-To: <85tvt1i4q6.fsf@mojatatu.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 27 Mar 2018 17:33:05 -0400 Roman Mashak wrote: > Stephen Hemminger writes: > > > On Mon, 19 Mar 2018 17:05:41 -0400 > > Roman Mashak wrote: > > > >> diff --git a/tc/m_gact.c b/tc/m_gact.c > >> index 16c4413f4217..52022415db48 100644 > >> --- a/tc/m_gact.c > >> +++ b/tc/m_gact.c > >> @@ -194,7 +194,7 @@ print_gact(struct action_util *au, FILE *f, struct rtattr *arg) > >> print_string(PRINT_ANY, "random_type", "\n\t random type %s", > >> prob_n2a(pp->ptype)); > >> print_action_control(f, " ", pp->paction, " "); > >> - print_int(PRINT_ANY, "val", "val %d", pp->pval); > >> + print_int(PRINT_ANY, "val", "val %u", pp->pval); > >> close_json_object(); > > > > This needs to be print_uint in order to work correctly with json output. > > > > Also, please consider doing json on all the match types in a later patch > > for net-next. > > Did you mean iproute2-next? yes. iproute2-next for the JSON changes