From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Watson <davejwatson@fb.com>
Subject: Re: [PATCH V4 net-next 06/14] net/tls: Add generic NIC offload
 infrastructure
Date: Tue, 27 Mar 2018 15:26:48 -0700
Message-ID: <20180327222648.GA58978@davejwatson-mba.local>
References: <20180327215201.18859-1-saeedm@mellanox.com>
 <20180327215201.18859-7-saeedm@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
        Boris Pismenny <borisp@mellanox.com>,
        Ilya Lesokhin <ilyal@mellanox.com>,
        Aviad Yehezkel <aviadye@mellanox.com>
To: Saeed Mahameed <saeedm@mellanox.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:32822 "EHLO
        mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1752502AbeC0W1F (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 27 Mar 2018 18:27:05 -0400
Content-Disposition: inline
In-Reply-To: <20180327215201.18859-7-saeedm@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Thanks for doing the merge, it looks good to me.  One issue below,
otherwise all my SW tests still pass.

On 03/27/18 02:51 PM, Saeed Mahameed wrote:
> -	if (ctx->conf == TLS_SW_TX ||
> -	    ctx->conf == TLS_SW_RX ||
> -	    ctx->conf == TLS_SW_RXTX) {
> -		tls_sw_free_resources(sk);
> +	if (ctx->rx_conf == TLS_SW) {
> +		kfree(ctx->rx.rec_seq);
> +		kfree(ctx->rx.iv);
> +		tls_sw_free_resources_rx(sk);
>  	}
>  
> +	if (ctx->tx_conf != TLS_HW)
> +		kfree(ctx);

Looks like this needs to be hidden behind CONFIG_TLS_DEVICE, otherwise
it doesn't compile if false because TLS_HW is not defined