From mboxrd@z Thu Jan  1 00:00:00 1970
From: Phil Sutter <phil@nwl.cc>
Subject: Re: [iproute PATCH 2/3] ss: Put filter DB parsing into a separate
 function
Date: Wed, 28 Mar 2018 01:39:54 +0200
Message-ID: <20180327233954.GZ6986@orbyte.nwl.cc>
References: <20180324181811.22615-1-phil@nwl.cc>
 <20180324181811.22615-3-phil@nwl.cc>
 <20180327114601.62112467@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: netdev@vger.kernel.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from orbyte.nwl.cc ([151.80.46.58]:46622 "EHLO orbyte.nwl.cc"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751874AbeC0Xj4 (ORCPT <rfc822;netdev@vger.kernel.org>);
        Tue, 27 Mar 2018 19:39:56 -0400
Content-Disposition: inline
In-Reply-To: <20180327114601.62112467@xeon-e3>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Tue, Mar 27, 2018 at 11:46:01AM -0700, Stephen Hemminger wrote:
> On Sat, 24 Mar 2018 19:18:10 +0100
> Phil Sutter <phil@nwl.cc> wrote:
> 
> > +#define ENTRY(name, ...) { #name, { __VA_ARGS__, MAX_DB }}
> 
> > +		ENTRY(all, UDP_DB, DCCP_DB, TCP_DB, RAW_DB, \
> > +			   UNIX_ST_DB, UNIX_DG_DB, UNIX_SQ_DB, \
> > +			   PACKET_R_DB, PACKET_DG_DB, NETLINK_DB, \
> > +			   SCTP_DB, VSOCK_ST_DB, VSOCK_DG_DB),
> 
> Checkpatch complains that line continuations are not necessary here;
> and it is right. Macro usage can cross lines.

Interesting. Seems I should fix my muscle memory when it comes to
macros. :)

I'll follow-up with a fixed version.

Thanks, Phil