From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sudarsana Reddy Kalluru Subject: [PATCH net-next v2 2/5] qed: Fix PTT entry leak in the selftest error flow. Date: Wed, 28 Mar 2018 01:43:28 -0700 Message-ID: <20180328084331.2435-3-sudarsana.kalluru@cavium.com> References: <20180328084331.2435-1-sudarsana.kalluru@cavium.com> Mime-Version: 1.0 Content-Type: text/plain Cc: , , To: Return-path: Received: from mail-co1nam03on0082.outbound.protection.outlook.com ([104.47.40.82]:62228 "EHLO NAM03-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752587AbeC1Inw (ORCPT ); Wed, 28 Mar 2018 04:43:52 -0400 In-Reply-To: <20180328084331.2435-1-sudarsana.kalluru@cavium.com> Sender: netdev-owner@vger.kernel.org List-ID: Signed-off-by: Sudarsana Reddy Kalluru Signed-off-by: Ariel Elior --- drivers/net/ethernet/qlogic/qed/qed_selftest.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/qed/qed_selftest.c b/drivers/net/ethernet/qlogic/qed/qed_selftest.c index b88082f..cf1d447 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_selftest.c +++ b/drivers/net/ethernet/qlogic/qed/qed_selftest.c @@ -128,7 +128,8 @@ int qed_selftest_nvram(struct qed_dev *cdev) rc = qed_mcp_bist_nvm_get_num_images(p_hwfn, p_ptt, &num_images); if (rc || !num_images) { DP_ERR(p_hwfn, "Failed getting number of images\n"); - return -EINVAL; + rc = -EINVAL; + goto err0; } /* Iterate over images and validate CRC */ -- 1.8.3.1