From: Steven Rostedt <rostedt@goodmis.org>
To: Alexei Starovoitov <ast@fb.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
netdev <netdev@vger.kernel.org>, kernel-team <kernel-team@fb.com>,
linux-api <linux-api@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v6 bpf-next 08/11] bpf: introduce BPF_RAW_TRACEPOINT
Date: Wed, 28 Mar 2018 10:06:53 -0400 [thread overview]
Message-ID: <20180328100653.3dad40b9@gandalf.local.home> (raw)
In-Reply-To: <34b9892d-c091-7b83-d8e8-79c0ff813140@fb.com>
On Tue, 27 Mar 2018 17:51:55 -0700
Alexei Starovoitov <ast@fb.com> wrote:
> Turned out it was in init.data section and got poisoned.
> this fixes it:
> @@ -258,6 +258,7 @@
> LIKELY_PROFILE() \
> BRANCH_PROFILE() \
> TRACE_PRINTKS() \
> + BPF_RAW_TP() \
> TRACEPOINT_STR()
>
> /*
> @@ -585,7 +586,6 @@
> *(.init.rodata) \
> FTRACE_EVENTS() \
> TRACE_SYSCALLS() \
> - BPF_RAW_TP() \
> KPROBE_BLACKLIST() \
> ERROR_INJECT_WHITELIST() \
> MEM_DISCARD(init.rodata) \
>
> and it works :)
> I will clean few other nits I found while debugging and respin.
Getting it properly working was an exercise left to the reader ;-)
Sorry about that, I did a bit of copy and paste to get it working, and
copied from code that did things a bit differently, so I massaged it by
hand, and doing it quickly as I had other things to work on.
-- Steve
next prev parent reply other threads:[~2018-03-28 14:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 2:46 [PATCH v6 bpf-next 00/11] bpf, tracing: introduce bpf raw tracepoints Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 01/11] treewide: remove large struct-pass-by-value from tracepoint arguments Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 02/11] net/mediatek: disambiguate mt76 vs mt7601u trace events Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 03/11] net/mac802154: disambiguate mac80215 vs mac802154 " Alexei Starovoitov
2018-03-27 2:46 ` [PATCH v6 bpf-next 04/11] net/wireless/iwlwifi: fix iwlwifi_dev_ucode_error tracepoint Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 05/11] macro: introduce COUNT_ARGS() macro Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 06/11] tracepoint: compute num_args at build time Alexei Starovoitov
2018-03-27 15:15 ` Steven Rostedt
2018-03-27 2:47 ` [PATCH v6 bpf-next 07/11] tracepoint: introduce kernel_tracepoint_find_by_name Alexei Starovoitov
2018-03-27 14:07 ` Steven Rostedt
2018-03-27 14:18 ` Mathieu Desnoyers
2018-03-27 14:42 ` Steven Rostedt
2018-03-27 15:53 ` Alexei Starovoitov
2018-03-27 16:09 ` Mathieu Desnoyers
2018-03-27 16:36 ` Daniel Borkmann
2018-03-27 2:47 ` [PATCH v6 bpf-next 08/11] bpf: introduce BPF_RAW_TRACEPOINT Alexei Starovoitov
2018-03-27 17:02 ` Steven Rostedt
2018-03-27 17:11 ` Steven Rostedt
2018-03-27 18:58 ` Steven Rostedt
2018-03-27 21:04 ` Steven Rostedt
2018-03-27 22:48 ` Alexei Starovoitov
2018-03-27 23:13 ` Mathieu Desnoyers
2018-03-28 0:00 ` Alexei Starovoitov
2018-03-28 0:44 ` Mathieu Desnoyers
2018-03-28 0:51 ` Alexei Starovoitov
2018-03-28 14:06 ` Steven Rostedt [this message]
2018-03-27 18:45 ` Alexei Starovoitov
2018-03-27 19:00 ` Steven Rostedt
2018-03-27 19:07 ` Steven Rostedt
2018-03-27 19:10 ` Steven Rostedt
2018-03-27 19:10 ` Mathieu Desnoyers
2018-03-27 2:47 ` [PATCH v6 bpf-next 09/11] libbpf: add bpf_raw_tracepoint_open helper Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 10/11] samples/bpf: raw tracepoint test Alexei Starovoitov
2018-03-27 2:47 ` [PATCH v6 bpf-next 11/11] selftests/bpf: test for bpf_get_stackid() from raw tracepoints Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180328100653.3dad40b9@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ast@fb.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=keescook@chromium.org \
--cc=kernel-team@fb.com \
--cc=linux-api@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).