From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: [PATCH net-next v2 0/3] net: Broadcom drivers coalescing fixes Date: Wed, 28 Mar 2018 15:15:35 -0700 Message-ID: <20180328221538.29290-1-f.fainelli@gmail.com> Cc: Florian Fainelli , davem@davemloft.net, jaedon.shin@gmail.com, pgynther@google.com, opendmb@gmail.com, Michael Chan , gospo@broadcom.com, talgi@mellanox.com, saeedm@mellanox.com To: netdev@vger.kernel.org Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:32805 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752606AbeC1WRE (ORCPT ); Wed, 28 Mar 2018 18:17:04 -0400 Received: by mail-pg0-f67.google.com with SMTP id i194so1719359pgd.0 for ; Wed, 28 Mar 2018 15:17:04 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: Hi all, Following Tal's review of the adaptive RX/TX coalescing feature added to the SYSTEMPORT and GENET driver a number of things showed up: - adaptive TX coalescing is not actually a good idea with the current way the estimator will program the ring, this results in a higher CPU load, NAPI on TX already does a reasonably good job at maintaining the interrupt count low - both SYSTEMPORT and GENET would suffer from the same issues while configuring coalescing parameters where the values would just not be applied correctly based on user settings, so we fix that too Tal, thanks again for your feedback, I would appreciate if you could review that the new behavior appears to be implemented correctly. Thanks! Changes in v2: - added Tal's reviewed-by to the first patch - split DIM initialization from coalescing parameters initialization - avoid duplicating the same code in bcmgenet_set_coalesce() when configuring RX rings - fixed the condition where default DIM parameters would be applied when adaptive RX coalescing would be enabled, do this only if it was disabled before Florian Fainelli (3): net: systemport: Remove adaptive TX coalescing net: systemport: Fix coalescing settings handling net: bcmgenet: Fix coalescing settings handling drivers/net/ethernet/broadcom/bcmsysport.c | 123 +++++++++++-------------- drivers/net/ethernet/broadcom/bcmsysport.h | 5 +- drivers/net/ethernet/broadcom/genet/bcmgenet.c | 92 +++++++++++------- drivers/net/ethernet/broadcom/genet/bcmgenet.h | 4 +- 4 files changed, 115 insertions(+), 109 deletions(-) -- 2.14.1