* [PATCH net] hv_netvsc: enable multicast if necessary
@ 2018-03-27 18:28 Stephen Hemminger
2018-03-29 15:46 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2018-03-27 18:28 UTC (permalink / raw)
To: davem; +Cc: netdev, Stephen Hemminger
My recent change to netvsc drive in how receive flags are handled
broke multicast. The Hyper-v/Azure virtual interface there is not a
multicast filter list, filtering is only all or none. The driver must
enable all multicast if any multicast address is present.
Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
drivers/net/hyperv/rndis_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 00ec80c23fe5..8799b0590adc 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -864,7 +864,7 @@ static void rndis_set_multicast(struct work_struct *w)
if (flags & IFF_PROMISC) {
filter = NDIS_PACKET_TYPE_PROMISCUOUS;
} else {
- if (flags & IFF_ALLMULTI)
+ if (!netdev_mc_empty(rdev->ndev) || (flags & IFF_ALLMULTI))
filter |= NDIS_PACKET_TYPE_ALL_MULTICAST;
if (flags & IFF_BROADCAST)
filter |= NDIS_PACKET_TYPE_BROADCAST;
--
2.16.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] hv_netvsc: enable multicast if necessary
2018-03-27 18:28 [PATCH net] hv_netvsc: enable multicast if necessary Stephen Hemminger
@ 2018-03-29 15:46 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-03-29 15:46 UTC (permalink / raw)
To: stephen; +Cc: netdev, sthemmin
From: Stephen Hemminger <stephen@networkplumber.org>
Date: Tue, 27 Mar 2018 11:28:48 -0700
> My recent change to netvsc drive in how receive flags are handled
> broke multicast. The Hyper-v/Azure virtual interface there is not a
> multicast filter list, filtering is only all or none. The driver must
> enable all multicast if any multicast address is present.
>
> Fixes: 009f766ca238 ("hv_netvsc: filter multicast/broadcast")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
Applied, thanks Stephen.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-29 15:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-27 18:28 [PATCH net] hv_netvsc: enable multicast if necessary Stephen Hemminger
2018-03-29 15:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).