From: David Miller <davem@davemloft.net>
To: dongli.zhang@oracle.com
Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, wei.liu2@citrix.com,
paul.durrant@citrix.com
Subject: Re: [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON()
Date: Thu, 29 Mar 2018 12:09:03 -0400 (EDT) [thread overview]
Message-ID: <20180329.120903.1175452061863560219.davem@davemloft.net> (raw)
In-Reply-To: <1522194136-11985-1-git-send-email-dongli.zhang@oracle.com>
From: Dongli Zhang <dongli.zhang@oracle.com>
Date: Wed, 28 Mar 2018 07:42:16 +0800
> The "BUG_ON(!frag_iter)" in function xenvif_rx_next_chunk() is triggered if
> the received sk_buff is malformed, that is, when the sk_buff has pattern
> (skb->data_len && !skb_shinfo(skb)->nr_frags). Below is a sample call
> stack:
We should fix the parts of the kernel which build illegal malformed
SKBs rather than adding checks to every driver in the tree.
I'm not applying this, sorry.
prev parent reply other threads:[~2018-03-29 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 23:42 [PATCH 1/1] xen-netback: process malformed sk_buff correctly to avoid BUG_ON() Dongli Zhang
2018-03-27 23:49 ` [Xen-devel] " Dongli Zhang
2018-03-28 9:21 ` Paul Durrant
2018-03-29 16:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329.120903.1175452061863560219.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dongli.zhang@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).