From: David Miller <davem@davemloft.net>
To: jakub.kicinski@netronome.com
Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
jiri@mellanox.com, idosch@mellanox.com, andy.roulin@gmail.com
Subject: Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink
Date: Thu, 29 Mar 2018 14:11:19 -0400 (EDT) [thread overview]
Message-ID: <20180329.141119.1343151558612891683.davem@davemloft.net> (raw)
In-Reply-To: <20180327183450.34d6e9b6@cakuba.netronome.com>
From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 27 Mar 2018 18:34:50 -0700
> On Tue, 27 Mar 2018 18:22:00 -0700, David Ahern wrote:
>> +void nsim_devlink_setup(struct netdevsim *ns)
>> +{
...
> nit: DaveM expressed preference to not have silent failures in a
> discussion about DebugFS, not sure it applies here, but why not
> handle errors?
Yes it is a concern.
David please address this as a follow-up.
Thanks.
next prev parent reply other threads:[~2018-03-29 18:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 1:21 [PATCH net-next 0/6] net: Allow FIB notifiers to fail add and replace David Ahern
2018-03-28 1:21 ` [PATCH net-next 1/6] net: Fix fib notifer to return errno David Ahern
2018-03-29 8:19 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 2/6] net: Move call_fib_rule_notifiers up in fib_nl_newrule David Ahern
2018-03-29 8:20 ` Ido Schimmel
2018-03-29 8:22 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 3/6] net/ipv4: Move call_fib_entry_notifiers up for new routes David Ahern
2018-03-29 8:22 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 4/6] net/ipv4: Allow notifier to fail route replace David Ahern
2018-03-29 8:23 ` Ido Schimmel
2018-03-28 1:21 ` [PATCH net-next 5/6] net/ipv6: Move call_fib6_entry_notifiers up for route adds David Ahern
2018-03-29 8:23 ` Ido Schimmel
2018-03-28 1:22 ` [PATCH net-next 6/6] netdevsim: Add simple FIB resource controller via devlink David Ahern
2018-03-28 1:34 ` Jakub Kicinski
2018-03-29 18:11 ` David Miller [this message]
2018-03-29 20:01 ` David Ahern
2018-04-05 17:27 ` Jiri Pirko
2018-04-05 20:10 ` David Ahern
2018-04-05 21:06 ` David Ahern
2018-04-06 5:52 ` Jiri Pirko
2018-04-06 21:22 ` David Ahern
2018-04-09 8:18 ` Jiri Pirko
2018-04-06 5:35 ` Jiri Pirko
2018-03-29 8:29 ` [PATCH net-next 0/6] net: Allow FIB notifiers to fail add and replace Ido Schimmel
2018-03-29 20:00 ` David Ahern
2018-03-29 18:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180329.141119.1343151558612891683.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy.roulin@gmail.com \
--cc=dsa@cumulusnetworks.com \
--cc=idosch@mellanox.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).