From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next 6/6] netdevsim: Add simple FIB resource
 controller via devlink
Date: Thu, 29 Mar 2018 14:11:19 -0400 (EDT)
Message-ID: <20180329.141119.1343151558612891683.davem@davemloft.net>
References: <20180328012200.15175-1-dsa@cumulusnetworks.com>
        <20180328012200.15175-7-dsa@cumulusnetworks.com>
        <20180327183450.34d6e9b6@cakuba.netronome.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: dsa@cumulusnetworks.com, netdev@vger.kernel.org,
        roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
        jiri@mellanox.com, idosch@mellanox.com, andy.roulin@gmail.com
To: jakub.kicinski@netronome.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:47422 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754412AbeC2SLU (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 29 Mar 2018 14:11:20 -0400
In-Reply-To: <20180327183450.34d6e9b6@cakuba.netronome.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Tue, 27 Mar 2018 18:34:50 -0700

> On Tue, 27 Mar 2018 18:22:00 -0700, David Ahern wrote:
>> +void nsim_devlink_setup(struct netdevsim *ns)
>> +{
 ...
> nit: DaveM expressed preference to not have silent failures in a
>      discussion about DebugFS, not sure it applies here, but why not
>      handle errors?

Yes it is a concern.

David please address this as a follow-up.

Thanks.