From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: hns3: remove unnecessary
 pci_set_drvdata() and devm_kfree()
Date: Thu, 29 Mar 2018 14:35:20 -0400 (EDT)
Message-ID: <20180329.143520.180872666601831050.davem@davemloft.net>
References: <1522241461-77556-1-git-send-email-weiyongjun1@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com,
        netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
To: weiyongjun1@huawei.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:47890 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751865AbeC2SfV (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 29 Mar 2018 14:35:21 -0400
In-Reply-To: <1522241461-77556-1-git-send-email-weiyongjun1@huawei.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 28 Mar 2018 12:51:01 +0000

> The devm_kfree function allocates memory that is released when a

devm_kfree doesn't allocate memory, it frees it.

Your commit log message is confusing at best.  I know what you're
trying to say, but a lot of the logic is reversed or hard to
understand.

Thank you.