From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next 2/6] net: Move call_fib_rule_notifiers up in fib_nl_newrule Date: Thu, 29 Mar 2018 11:22:39 +0300 Message-ID: <20180329082239.GC22733@splinter> References: <20180328012200.15175-1-dsa@cumulusnetworks.com> <20180328012200.15175-3-dsa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, andy.roulin@gmail.com To: David Ahern Return-path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:41803 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbeC2IWl (ORCPT ); Thu, 29 Mar 2018 04:22:41 -0400 Content-Disposition: inline In-Reply-To: <20180328012200.15175-3-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Mar 27, 2018 at 06:21:56PM -0700, David Ahern wrote: > Move call_fib_rule_notifiers up in fib_nl_newrule to the point right > before the rule is inserted into the list. At this point there are no > more failure paths within the core rule code, so if the notifier > does not fail then the rule will be inserted into the list. > > Signed-off-by: David Ahern BTW, this means we can now return an error from mlxsw instead of only emitting an extack warning when an unsupported FIB rule is configured. Will add that.