From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ido Schimmel Subject: Re: [PATCH net-next 3/6] net/ipv4: Move call_fib_entry_notifiers up for new routes Date: Thu, 29 Mar 2018 11:22:58 +0300 Message-ID: <20180329082258.GD22733@splinter> References: <20180328012200.15175-1-dsa@cumulusnetworks.com> <20180328012200.15175-4-dsa@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, roopa@cumulusnetworks.com, shm@cumulusnetworks.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, andy.roulin@gmail.com To: David Ahern Return-path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:53571 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbeC2IXB (ORCPT ); Thu, 29 Mar 2018 04:23:01 -0400 Content-Disposition: inline In-Reply-To: <20180328012200.15175-4-dsa@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Mar 27, 2018 at 06:21:57PM -0700, David Ahern wrote: > Move call to call_fib_entry_notifiers for new IPv4 routes to right > before the call to fib_insert_alias. At this point the only remaining > failure path is memory allocations in fib_insert_node. Handle that > very unlikely failure with a call to call_fib_entry_notifiers to > tell drivers about it. > > At this point notifier handlers can decide the fate of the new route > with a clean path to delete the potential new entry if the notifier > returns non-0. > > Signed-off-by: David Ahern Reviewed-by: Ido Schimmel