netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sabrina Dubroca <sd@queasysnail.net>
To: Atul Gupta <atul.gupta@chelsio.com>
Cc: davem@davemloft.net, herbert@gondor.apana.org.au,
	davejwatson@fb.com, sbrivio@redhat.com,
	linux-crypto@vger.kernel.org, netdev@vger.kernel.org,
	werner@chelsio.com, leedom@chelsio.com,
	swise@opengridcomputing.com, indranil@chelsio.com,
	ganeshgr@chelsio.com
Subject: Re: [PATCH v14 net-next 08/12] crypto : chtls - CPL handler definition
Date: Thu, 29 Mar 2018 18:26:23 +0200	[thread overview]
Message-ID: <20180329162623.GA9805@bistromath.localdomain> (raw)
In-Reply-To: <1522339074-4681-9-git-send-email-atul.gupta@chelsio.com>

2018-03-29, 21:27:50 +0530, Atul Gupta wrote:
...
> +static void chtls_pass_accept_request(struct sock *sk,
> +				      struct sk_buff *skb)
> +{
...
> +	if (chtls_get_module(newsk))
> +		goto reject;
> +	inet_csk_reqsk_queue_added(sk);
> +	reply_skb->sk = newsk;
> +	chtls_install_cpl_ops(newsk);

Function defined in patch 11, declared in patch 6, and used in patch
8.  Are you actually listening to the comments we've been sending?

-- 
Sabrina

  reply	other threads:[~2018-03-29 16:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 15:57 [PATCH v14 net-next 00/12] Chelsio Inline TLS Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 01/12] tls: support for Inline tls record Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 02/12] ethtool: enable Inline TLS in HW Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 03/12] cxgb4: Inline TLS FW Interface Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 04/12] cxgb4: LLD driver changes to support TLS Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 05/12] crypto: chcr - Inline TLS Key Macros Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 06/12] crypto: chtls - structure and macro for Inline TLS Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 07/12] crypto: chtls - Program the TLS session Key Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 08/12] crypto : chtls - CPL handler definition Atul Gupta
2018-03-29 16:26   ` Sabrina Dubroca [this message]
2018-03-29 19:08     ` Atul Gupta
2018-03-30 15:41       ` Ganesh Goudar
2018-03-29 15:57 ` [PATCH v14 net-next 09/12] crypto: chtls - Inline TLS record Tx Atul Gupta
2018-03-29 16:26   ` Sabrina Dubroca
2018-03-29 19:24     ` Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 10/12] crypto: chtls - Inline TLS record Rx Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 11/12] crypto: chtls - Register chtls with net tls Atul Gupta
2018-03-29 15:57 ` [PATCH v14 net-next 12/12] crypto: chtls - Makefile Kconfig Atul Gupta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329162623.GA9805@bistromath.localdomain \
    --to=sd@queasysnail.net \
    --cc=atul.gupta@chelsio.com \
    --cc=davejwatson@fb.com \
    --cc=davem@davemloft.net \
    --cc=ganeshgr@chelsio.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=indranil@chelsio.com \
    --cc=leedom@chelsio.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=swise@opengridcomputing.com \
    --cc=werner@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).