From: David Miller <davem@davemloft.net>
To: dsahern@gmail.com
Cc: netdev@vger.kernel.org, mfadon@teldat.com
Subject: Re: [PATCH net] vrf: Fix use after free and double free in vrf_finish_output
Date: Fri, 30 Mar 2018 14:21:10 -0400 (EDT) [thread overview]
Message-ID: <20180330.142110.2002113570787141626.davem@davemloft.net> (raw)
In-Reply-To: <20180329194952.27097-1-dsahern@gmail.com>
From: David Ahern <dsahern@gmail.com>
Date: Thu, 29 Mar 2018 12:49:52 -0700
> Miguel reported an skb use after free / double free in vrf_finish_output
> when neigh_output returns an error. The vrf driver should return after
> the call to neigh_output as it takes over the skb on error path as well.
>
> Patch is a simplified version of Miguel's patch which was written for 4.9,
> and updated to top of tree.
>
> Fixes: 8f58336d3f78a ("net: Add ethernet header for pass through VRF device")
> Signed-off-by: Miguel Fadon Perlines <mfadon@teldat.com>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Applied and queued up for -stable, thanks David.
prev parent reply other threads:[~2018-03-30 18:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 19:49 [PATCH net] vrf: Fix use after free and double free in vrf_finish_output David Ahern
2018-03-30 18:21 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330.142110.2002113570787141626.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=mfadon@teldat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox