From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [PATCH net-next 2/3] netfilter: Rework xt_TEE netdevice notifier Date: Fri, 30 Mar 2018 11:47:45 +0200 Message-ID: <20180330094745.stx5hq5qx2qi3l7u@salvia> References: <152233127015.1654.2122693690388452589.stgit@localhost.localdomain> <152233221526.1654.14062155454284081692.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, steffen.klassert@secunet.com, herbert@gondor.apana.org.au, kadlec@blackhole.kfki.hu, fw@strlen.de, daniel@iogearbox.net, jakub.kicinski@netronome.com, ast@kernel.org, brouer@redhat.com, linux@rasmusvillemoes.dk, john.fastabend@gmail.com, dsahern@gmail.com, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org To: Kirill Tkhai Return-path: Received: from mail.us.es ([193.147.175.20]:53810 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082AbeC3Jrw (ORCPT ); Fri, 30 Mar 2018 05:47:52 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 6AA2A5B852 for ; Fri, 30 Mar 2018 11:47:32 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5B98EDA270 for ; Fri, 30 Mar 2018 11:47:32 +0200 (CEST) Content-Disposition: inline In-Reply-To: <152233221526.1654.14062155454284081692.stgit@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Mar 29, 2018 at 05:03:35PM +0300, Kirill Tkhai wrote: > Register netdevice notifier for every iptable entry > is not good, since this breaks modularity, and > the hidden synchronization is based on rtnl_lock(). > > This patch reworks the synchronization via new lock, > while the rest of logic remains as it was before. > This is required for the next patch. > > Tested via: > > while :; do > unshare -n iptables -t mangle -A OUTPUT -j TEE --gateway 1.1.1.2 --oif lo; > done > > Signed-off-by: Kirill Tkhai Acked-by: Pablo Neira Ayuso