From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH net-next 0/9] devlink: Add support for region access Date: Fri, 30 Mar 2018 12:24:42 +0200 Message-ID: <20180330102442.GB3313@nanopsycho> References: <1522339672-18273-1-git-send-email-valex@mellanox.com> <20180329182343.GB12150@lunn.ch> <20180330095156.GA24242@chelsio.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Lunn , Alex Vesker , "David S. Miller" , "netdev@vger.kernel.org" , Tariq Toukan , Jiri Pirko To: Rahul Lakkireddy Return-path: Received: from mail-wr0-f179.google.com ([209.85.128.179]:36464 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbeC3KYo (ORCPT ); Fri, 30 Mar 2018 06:24:44 -0400 Received: by mail-wr0-f179.google.com with SMTP id y55so7673637wry.3 for ; Fri, 30 Mar 2018 03:24:43 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180330095156.GA24242@chelsio.com> Sender: netdev-owner@vger.kernel.org List-ID: Fri, Mar 30, 2018 at 11:51:57AM CEST, rahul.lakkireddy@chelsio.com wrote: >On Thursday, March 03/29/18, 2018 at 23:53:43 +0530, Andrew Lunn wrote: >> On Thu, Mar 29, 2018 at 07:07:43PM +0300, Alex Vesker wrote: >> > This is a proposal which will allow access to driver defined address >> > regions using devlink. Each device can create its supported address >> > regions and register them. A device which exposes a region will allow >> > access to it using devlink. >> >> Hi Alex >> >> Did you see the work Rahul Lakkireddy has been doing? >> >> https://patchwork.kernel.org/patch/10305935/ >> >> It seems like these are similar, or at least overlapping. We probably >> want one solution for both. >> > >We're already collecting hardware snapshots when system is live with >ethtool --getdump (which devlink tool is now trying to do). Ethtool is definitelly a wrong tool for this. It uses netdev as a handle, but the dumps happen on a parent device - represented by a devlink instance. Also, in devlink we have notifications so a deamon can actually listen on a socket to see if there is new dump available due to a critical event etc. > >We are now in the process of adding support to collect hardware >snapshots during kernel panic. > >Thanks, >Rahul