From: Christoph Hellwig <hch@infradead.org>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, netdev@vger.kernel.org,
Sathya Perla <sathya.perla@broadcom.com>,
Felix Manlunas <felix.manlunas@caviumnetworks.com>,
alexander.duyck@gmail.com, john.fastabend@gmail.com,
Jacob Keller <jacob.e.keller@intel.com>,
Donald Dutile <ddutile@redhat.com>,
oss-drivers@netronome.com
Subject: Re: [PATCH] PCI: allow drivers to limit the number of VFs to 0
Date: Fri, 30 Mar 2018 04:49:05 -0700 [thread overview]
Message-ID: <20180330114905.GA10246@infradead.org> (raw)
In-Reply-To: <20180329182231.32151-1-jakub.kicinski@netronome.com>
On Thu, Mar 29, 2018 at 11:22:31AM -0700, Jakub Kicinski wrote:
> Some user space depends on driver allowing sriov_totalvfs to be
> enabled.
I can't make sene of this sentence. Can you explain what user space
code depends on what semantics? The sriov_totalvfs file should show
up for any device supporting SR-IOV as far as I can tell.
>
> For devices which VF support depends on loaded FW we
> have the pci_sriov_{g,s}et_totalvfs() API. However, this API
> uses 0 as a special "unset" value, meaning drivers can't limit
> sriov_totalvfs to 0. Change the special value to be U16_MAX.
> Use simple min() to determine actual totalvfs.
Please use a PCI_MAX_VFS or similar define instead of plain U16_MAX or ~0.
next prev parent reply other threads:[~2018-03-30 11:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 18:22 [PATCH] PCI: allow drivers to limit the number of VFs to 0 Jakub Kicinski
2018-03-30 11:49 ` Christoph Hellwig [this message]
2018-03-30 16:54 ` Alexander Duyck
2018-04-02 21:18 ` Jakub Kicinski
2018-04-02 21:17 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2018-04-02 22:46 Jakub Kicinski
2018-05-24 23:57 ` Bjorn Helgaas
2018-05-25 1:20 ` Jakub Kicinski
2018-05-25 14:02 ` Bjorn Helgaas
2018-05-25 17:01 ` Bjorn Helgaas
2018-05-25 17:46 ` Keller, Jacob E
2018-05-25 19:27 ` Don Dutile
2018-05-25 20:46 ` Bjorn Helgaas
2018-05-29 14:29 ` Don Dutile
2018-05-25 21:05 ` Jakub Kicinski
2018-05-25 21:45 ` Bjorn Helgaas
2018-05-29 14:34 ` Don Dutile
2018-06-19 21:37 ` Bjorn Helgaas
2018-06-20 2:56 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330114905.GA10246@infradead.org \
--to=hch@infradead.org \
--cc=alexander.duyck@gmail.com \
--cc=bhelgaas@google.com \
--cc=ddutile@redhat.com \
--cc=felix.manlunas@caviumnetworks.com \
--cc=jacob.e.keller@intel.com \
--cc=jakub.kicinski@netronome.com \
--cc=john.fastabend@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=sathya.perla@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).