From: Andrew Lunn <andrew@lunn.ch>
To: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Cc: torvalds@linux-foundation.org, linux-kernel@vger.kernel.org,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] fix typo in command value in drivers/net/phy/mdio-bitbang.
Date: Fri, 30 Mar 2018 16:14:09 +0200 [thread overview]
Message-ID: <20180330141409.GC28244@lunn.ch> (raw)
In-Reply-To: <CACW_hTauBL6but9143Kio-ZU5jsMKx2uTEUv3kHFaTGuwdyHZA@mail.gmail.com>
On Fri, Mar 30, 2018 at 02:03:38PM +0200, Frans Meulenbroeks wrote:
> mdio-bitbang mentioned 10 for both read and write.
> However mdio read opcode is 10 and write opcode is 01
> Fixed comment.
>
> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks@gmail.com>
Hi Frans
The correct place to send this patch is <netdev@vger.kernel.org> and
David Miller <davem@davemloft.net>. Please can you submit it again, to
these addresses.
In general, if you don't know where to send a patch,
scripts/get_maintainers.pl will tell you.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
> ---
> drivers/net/phy/mdio-bitbang.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
> index 61a543c..403b085 100644
> --- a/drivers/net/phy/mdio-bitbang.c
> +++ b/drivers/net/phy/mdio-bitbang.c
> @@ -113,7 +113,7 @@ static void mdiobb_cmd(struct mdiobb_ctrl *ctrl, int
> op, u8 phy, u8 reg)
> for (i = 0; i < 32; i++)
> mdiobb_send_bit(ctrl, 1);
>
> - /* send the start bit (01) and the read opcode (10) or write (10).
> + /* send the start bit (01) and the read opcode (10) or write (01).
> Clause 45 operation uses 00 for the start and 11, 10 for
> read/write */
> mdiobb_send_bit(ctrl, 0);
> --
> 2.7.4
parent reply other threads:[~2018-03-30 14:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <CACW_hTauBL6but9143Kio-ZU5jsMKx2uTEUv3kHFaTGuwdyHZA@mail.gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180330141409.GC28244@lunn.ch \
--to=andrew@lunn.ch \
--cc=fransmeulenbroeks@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).