netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net] vlan: also check phy_driver ts_info for vlan's real device
Date: Fri, 30 Mar 2018 08:21:21 -0700	[thread overview]
Message-ID: <20180330152121.rmvdkjrqmhekasnh@localhost> (raw)
In-Reply-To: <20180330150214.GF28244@lunn.ch>

On Fri, Mar 30, 2018 at 05:02:14PM +0200, Andrew Lunn wrote:
> Would it not be better to just call ethtool_get_ts_info() on the real
> device? That would then also deal with the case that the 'real' device
> is another virtual device stacked on top of a real device.

That won't work.

The returned 'ethtool_ts_info' is on the stack of
ethtool_get_ts_info().  Both the top level and the inner call to
will call copy_to_user(), but the top level will clobber the correct
result with zeros.

Thanks,
Richard

  reply	other threads:[~2018-03-30 15:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30  1:44 [PATCH net] vlan: also check phy_driver ts_info for vlan's real device Hangbin Liu
2018-03-30 15:02 ` Andrew Lunn
2018-03-30 15:21   ` Richard Cochran [this message]
2018-03-30 15:36     ` Andrew Lunn
2018-04-02  0:56 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180330152121.rmvdkjrqmhekasnh@localhost \
    --to=richardcochran@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=liuhangbin@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).