From mboxrd@z Thu Jan  1 00:00:00 1970
From: Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH net-next 4/6] inet: frags: use rhashtables for reassembly
 units
Date: Sat, 31 Mar 2018 00:37:38 +0800
Message-ID: <20180330163738.GA27660@gondor.apana.org.au>
References: <20180330052241.206667-2-edumazet@google.com>
 <20180330052241.206667-5-edumazet@google.com>
 <20180330071814.GA27025@gondor.apana.org.au>
 <bc46ffdc-e3c4-93be-39ab-76c2634f2c6e@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Eric Dumazet <edumazet@google.com>,
        "David S . Miller" <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>, Florian Westphal <fw@strlen.de>,
        Thomas Graf <tgraf@suug.ch>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Alexander Aring <alex.aring@gmail.com>,
        Stefan Schmidt <stefan@osg.samsung.com>,
        Nikolay Aleksandrov <nikolay@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from orcrist.hmeau.com ([104.223.48.154]:51456 "EHLO
        deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751167AbeC3Qh4 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 30 Mar 2018 12:37:56 -0400
Content-Disposition: inline
In-Reply-To: <bc46ffdc-e3c4-93be-39ab-76c2634f2c6e@gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Fri, Mar 30, 2018 at 06:30:42AM -0700, Eric Dumazet wrote:
> 
> I guess I will need to add a cond_resched() in it, right ?

I only ever run with preemption enabled :)

But yeah we should probably add some cond_rescheds to it.  While
you're at it you might want to add some to these functions too:
 - nested_table_free
 - bucket_table_alloc
 - rhashtable_rehash_table

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt