From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 0/2] net: bridge: MTU handling changes Date: Sat, 31 Mar 2018 22:05:16 -0400 (EDT) Message-ID: <20180331.220516.312380228110627327.davem@davemloft.net> References: <20180330104619.31479-1-nikolay@cumulusnetworks.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, roopa@cumulusnetworks.com, makita.toshiaki@lab.ntt.co.jp, 3chas3@gmail.com, stephen@networkplumber.org, bridge@lists.linux-foundation.org To: nikolay@cumulusnetworks.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:49604 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752826AbeDACFS (ORCPT ); Sat, 31 Mar 2018 22:05:18 -0400 In-Reply-To: <20180330104619.31479-1-nikolay@cumulusnetworks.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Nikolay Aleksandrov Date: Fri, 30 Mar 2018 13:46:17 +0300 > As previously discussed the recent changes break some setups and could lead > to packet drops. Thus the first patch reverts the behaviour for the bridge > to follow the minimum MTU but also keeps the ability to set the MTU to the > maximum (out of all ports) if vlan filtering is enabled. Patch 02 is the > bigger change in behaviour - we've always had trouble when configuring > bridges and their MTU which is auto tuning on port events > (add/del/changemtu), which means config software needs to chase it and fix > it after each such event, after patch 02 we allow the user to configure any > MTU (ETH_MIN/MAX limited) but once that is done the bridge stops auto > tuning and relies on the user to keep the MTU correct. > This should be compatible with cases that don't touch the MTU (or set it > to the same value), while allowing to configure the MTU and not worry > about it changing afterwards. > > The patches are intentionally split like this, so that if they get accepted > and there are any complaints patch 02 can be reverted. Series applied, thanks.