From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH RESEND net-next 0/2] net_rwsem fixes Date: Sat, 31 Mar 2018 22:25:14 -0400 (EDT) Message-ID: <20180331.222514.944117833941358821.davem@davemloft.net> References: <152242784495.18864.4373352355749698367.stgit@localhost.localdomain> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: zhangshengju@cmss.chinamobile.com, jakub.kicinski@netronome.com, dsahern@gmail.com, mschiffer@universe-factory.net, daniel@iogearbox.net, netdev@vger.kernel.org To: ktkhai@virtuozzo.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:49768 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752454AbeDACZQ (ORCPT ); Sat, 31 Mar 2018 22:25:16 -0400 In-Reply-To: <152242784495.18864.4373352355749698367.stgit@localhost.localdomain> Sender: netdev-owner@vger.kernel.org List-ID: From: Kirill Tkhai Date: Fri, 30 Mar 2018 19:38:16 +0300 > there is wext_netdev_notifier_call()->wireless_nlevent_flush() > netdevice notifier, which takes net_rwsem, so we can't take > net_rwsem in {,un}register_netdevice_notifier(). > > Since {,un}register_netdevice_notifier() is executed under > pernet_ops_rwsem, net_namespace_list can't change, while we > holding it, so there is no need net_rwsem in these functions [1/2]. > > The same is in [2/2]. We make callers of __rtnl_link_unregister() > take pernet_ops_rwsem, and close the race with setup_net() > and cleanup_net(), so __rtnl_link_unregister() does not need it. > This also fixes the problem of that __rtnl_link_unregister() does > not see initializing and exiting nets. Series applied.