From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v4 net-next 00/19] inet: frags: bring rhashtables to IP defrag Date: Sat, 31 Mar 2018 23:25:58 -0400 (EDT) Message-ID: <20180331.232558.823542518953124984.davem@davemloft.net> References: <20180331195900.183604-1-edumazet@google.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, fw@strlen.de, herbert@gondor.apana.org.au, tgraf@suug.ch, brouer@redhat.com, alex.aring@gmail.com, stefan@osg.samsung.com, ktkhai@virtuozzo.com, eric.dumazet@gmail.com To: edumazet@google.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:50180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbeDAD0A (ORCPT ); Sat, 31 Mar 2018 23:26:00 -0400 In-Reply-To: <20180331195900.183604-1-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Eric Dumazet Date: Sat, 31 Mar 2018 12:58:41 -0700 > IP defrag processing is one of the remaining problematic layer in linux. > > It uses static hash tables of 1024 buckets, and up to 128 items per bucket. > > A work queue is supposed to garbage collect items when host is under memory > pressure, and doing a hash rebuild, changing seed used in hash computations. > > This work queue blocks softirqs for up to 25 ms when doing a hash rebuild, > occurring every 5 seconds if host is under fire. > > Then there is the problem of sharing this hash table for all netns. > > It is time to switch to rhashtables, and allocate one of them per netns > to speedup netns dismantle, since this is a critical metric these days. > > Lookup is now using RCU, and 64bit hosts can now provision whatever amount > of memory needed to handle the expected workloads. ... Series applied, thanks Eric.