From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [net-next V8 PATCH 01/16] mlx5: basic XDP_REDIRECT forward
 support
Date: Sat, 31 Mar 2018 23:31:15 -0400 (EDT)
Message-ID: <20180331.233115.994657800927602157.davem@davemloft.net>
References: <152249785004.28297.14544687552072300815.stgit@firesoul>
        <152249795210.28297.14005981548436322464.stgit@firesoul>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, bjorn.topel@intel.com,
        magnus.karlsson@intel.com, eugenia@mellanox.com,
        jasowang@redhat.com, john.fastabend@gmail.com, eranbe@mellanox.com,
        saeedm@mellanox.com, galp@mellanox.com, borkmann@iogearbox.net,
        alexei.starovoitov@gmail.com, tariqt@mellanox.com
To: brouer@redhat.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:50250 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752907AbeDADbS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sat, 31 Mar 2018 23:31:18 -0400
In-Reply-To: <152249795210.28297.14005981548436322464.stgit@firesoul>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Jesper Dangaard Brouer <brouer@redhat.com>
Date: Sat, 31 Mar 2018 14:05:52 +0200

> +static inline void mlx5e_page_dma_unmap(struct mlx5e_rq *rq,
> +					struct mlx5e_dma_info *dma_info)

Please do not use the inline keyword in foo.c files, let the compiler
decide.

I know that this is done in other areas of this file, that just means
that I didn't catch it when those changes went it, rather than meaning
that the rule can be broken because it has been already.

Thank you.