From mboxrd@z Thu Jan  1 00:00:00 1970
From: kbuild test robot <lkp@intel.com>
Subject: Re: [net-next V7 PATCH 12/16] page_pool: refurbish version of
 page_pool code
Date: Sat, 31 Mar 2018 03:58:51 +0800
Message-ID: <201803310337.jMYE6K1P%fengguang.wu@intel.com>
References: <152234291739.17048.7135649249513438321.stgit@firesoul>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
        =?iso-8859-1?Q?Bj=F6rnT=F6pel?= <bjorn.topel@intel.com>,
        magnus.karlsson@intel.com, eugenia@mellanox.com,
        Jason Wang <jasowang@redhat.com>,
        John Fastabend <john.fastabend@gmail.com>,
        Eran Ben Elisha <eranbe@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>, galp@mellanox.com,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        Daniel Borkmann <borkmann@iogearbox.net>,
        Alexei Starovoitov <alexei.starovoitov@gmail.com>,
        Tariq Toukan <tariqt@mellanox.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga18.intel.com ([134.134.136.126]:51796 "EHLO mga18.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752455AbeC3T7V (ORCPT <rfc822;netdev@vger.kernel.org>);
        Fri, 30 Mar 2018 15:59:21 -0400
Content-Disposition: inline
In-Reply-To: <152234291739.17048.7135649249513438321.stgit@firesoul>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Hi Jesper,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Jesper-Dangaard-Brouer/XDP-redirect-memory-return-API/20180330-203122
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> net/core/page_pool.c:17:5: sparse: symbol 'page_pool_init' was not declared. Should it be static?
>> net/core/page_pool.c:198:6: sparse: symbol '__page_pool_recycle_into_ring' was not declared. Should it be static?
>> net/core/page_pool.c:267:6: sparse: symbol '__page_pool_empty_ring' was not declared. Should it be static?
>> net/core/page_pool.c:282:6: sparse: symbol '__page_pool_destroy_rcu' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation