From: Andrew Lunn <andrew@lunn.ch>
To: Alex Vesker <valex@mellanox.com>
Cc: David Ahern <dsahern@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Tariq Toukan <tariqt@mellanox.com>,
Jiri Pirko <jiri@mellanox.com>
Subject: Re: [PATCH net-next 0/9] devlink: Add support for region access
Date: Sat, 31 Mar 2018 17:53:45 +0200 [thread overview]
Message-ID: <20180331155345.GA14758@lunn.ch> (raw)
In-Reply-To: <f881a7f1-1296-801f-994b-564538f224c5@mellanox.com>
> I want to be able to login to a customer and accessing this snapshot
> without any previous configuration from the user and not asking for
> enabling the feature and then waiting for a repro...this will help
> debugging issues that are hard to reproduce, I don't see any reason
> to disable this.
The likely reality is 99.9% of these snapshots will never be seen or
used. But they take up memory sitting there doing nothing. And if the
snapshot is 2GB, that is a lot of memory. I expect a system admin
wants to be able to choose to enable this feature or not, because of
that memory. You should also consider implementing the memory pressure
callbacks, so you can discard snapshots, rather than OOM the machine.
Andrew
next prev parent reply other threads:[~2018-03-31 15:53 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 16:07 [PATCH net-next 0/9] devlink: Add support for region access Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 1/9] devlink: Add support for creating and destroying regions Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 2/9] devlink: Add callback to query for snapshot id before snapshot create Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 3/9] devlink: Add support for creating region snapshots Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 4/9] devlink: Add support for region get command Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 5/9] devlink: Extend the support querying for region snapshot IDs Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 6/9] devlink: Add support for region snapshot delete command Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 7/9] devlink: Add support for region snapshot read command Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 8/9] net/mlx4_core: Add health buffer address capability Alex Vesker
2018-03-29 16:07 ` [PATCH net-next 9/9] net/mlx4_core: Add Crdump FW snapshot support Alex Vesker
2018-03-29 17:13 ` [PATCH net-next 0/9] devlink: Add support for region access Andrew Lunn
2018-03-29 18:59 ` Alex Vesker
2018-03-29 19:51 ` Andrew Lunn
2018-03-30 5:28 ` Alex Vesker
2018-03-30 14:34 ` Andrew Lunn
2018-03-30 16:57 ` David Ahern
2018-03-30 19:39 ` Alex Vesker
2018-03-30 22:26 ` David Ahern
2018-03-31 6:11 ` Alex Vesker
2018-03-31 15:53 ` Andrew Lunn [this message]
2018-03-31 17:21 ` David Ahern
2018-04-04 11:07 ` Alex Vesker
2018-03-30 18:07 ` David Miller
2018-03-30 10:21 ` Jiri Pirko
2018-03-30 18:07 ` David Miller
2018-03-29 18:23 ` Andrew Lunn
2018-03-30 9:51 ` Rahul Lakkireddy
2018-03-30 10:24 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180331155345.GA14758@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=valex@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).