From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] ibmvnic: Disable irqs before exiting reset from closed state Date: Sun, 01 Apr 2018 20:56:33 -0400 (EDT) Message-ID: <20180401.205633.1756840906265553956.davem@davemloft.net> References: <4511c12c-0a2a-8d46-531d-2bdc1293ca00@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, tlfalcon@linux.vnet.ibm.com, nfont@linux.vnet.ibm.com To: jallen@linux.vnet.ibm.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:59568 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753992AbeDBA4f (ORCPT ); Sun, 1 Apr 2018 20:56:35 -0400 In-Reply-To: <4511c12c-0a2a-8d46-531d-2bdc1293ca00@linux.vnet.ibm.com> Sender: netdev-owner@vger.kernel.org List-ID: From: John Allen Date: Fri, 30 Mar 2018 13:44:21 -0500 > When the driver is closed, all the associated irqs are disabled. In the > event that the driver exits a reset in the closed state, we should be > consistent with the state we are in directly after a close. So before we > exit the reset routine, all irqs should be disabled as well. This will > prevent the irqs from being enabled twice in this case and reporting a > number of noisy warning traces. > > Signed-off-by: John Allen Applied.