Re: [PATCH net-next] net/broadcom: Fixup broken build due to function name change

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2634 bytes --]

Hi Tal,

I love your patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Tal-Gilboa/net-broadcom-Fixup-broken-build-due-to-function-name-change/20180401-145037
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=xtensa 

All errors (new ones prefixed by >>):

   drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function 'bcmgenet_set_ring_rx_coalesce':
>> drivers/net/ethernet/broadcom/genet/bcmgenet.c:655:11: error: implicit declaration of function 'net_dim_get_def_rx_moderation'; did you mean 'net_dim_get_def_profile'? [-Werror=implicit-function-declaration]
      moder = net_dim_get_def_rx_moderation(ring->dim.dim.mode);
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              net_dim_get_def_profile
>> drivers/net/ethernet/broadcom/genet/bcmgenet.c:655:9: error: incompatible types when assigning to type 'struct net_dim_cq_moder' from type 'int'
      moder = net_dim_get_def_rx_moderation(ring->dim.dim.mode);
            ^
   drivers/net/ethernet/broadcom/genet/bcmgenet.c: In function 'bcmgenet_init_rx_coalesce':
   drivers/net/ethernet/broadcom/genet/bcmgenet.c:2104:9: error: incompatible types when assigning to type 'struct net_dim_cq_moder' from type 'int'
      moder = net_dim_get_def_rx_moderation(dim->dim.mode);
            ^
   cc1: some warnings being treated as errors

vim +655 drivers/net/ethernet/broadcom/genet/bcmgenet.c

   642	
   643	static void bcmgenet_set_ring_rx_coalesce(struct bcmgenet_rx_ring *ring,
   644						  struct ethtool_coalesce *ec)
   645	{
   646		struct net_dim_cq_moder moder;
   647		u32 usecs, pkts;
   648	
   649		ring->rx_coalesce_usecs = ec->rx_coalesce_usecs;
   650		ring->rx_max_coalesced_frames = ec->rx_max_coalesced_frames;
   651		usecs = ring->rx_coalesce_usecs;
   652		pkts = ring->rx_max_coalesced_frames;
   653	
   654		if (ec->use_adaptive_rx_coalesce && !ring->dim.use_dim) {
 > 655			moder = net_dim_get_def_rx_moderation(ring->dim.dim.mode);
   656			usecs = moder.usec;
   657			pkts = moder.pkts;
   658		}
   659	
   660		ring->dim.use_dim = ec->use_adaptive_rx_coalesce;
   661		bcmgenet_set_rx_coalesce(ring, usecs, pkts);
   662	}
   663	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53225 bytes --]