From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH net-next V2 4/4] net/mlx5e: Enable adaptive-TX
 moderation
Date: Mon, 02 Apr 2018 10:26:36 -0400 (EDT)
Message-ID: <20180402.102636.256697366703977259.davem@davemloft.net>
References: <1522677574-7506-1-git-send-email-talgi@mellanox.com>
        <1522677574-7506-5-git-send-email-talgi@mellanox.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, tariqt@mellanox.com, saeedm@mellanox.com,
        f.fainelli@gmail.com
To: talgi@mellanox.com
Return-path: <netdev-owner@vger.kernel.org>
Received: from shards.monkeyblade.net ([184.105.139.130]:37772 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751344AbeDBO0i (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 2 Apr 2018 10:26:38 -0400
In-Reply-To: <1522677574-7506-5-git-send-email-talgi@mellanox.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

From: Tal Gilboa <talgi@mellanox.com>
Date: Mon,  2 Apr 2018 16:59:34 +0300

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c b/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> index 1b286e1..9cec351 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_dim.c
> @@ -33,16 +33,30 @@
>  #include <linux/net_dim.h>
>  #include "en.h"
>  
> +static inline void
> +mlx5e_complete_dim_work(struct net_dim *dim, struct net_dim_cq_moder moder,
> +			struct mlx5_core_dev *mdev, struct mlx5_core_cq *mcq)

Do not use inline in foo.c files, let the compiler decide.

> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> index f292bb3..ff1d5fe 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c
> @@ -44,6 +44,30 @@ static inline bool mlx5e_channel_no_affinity_change(struct mlx5e_channel *c)
>  	return cpumask_test_cpu(current_cpu, aff);
>  }
>  
> +static inline void mlx5e_handle_tx_dim(struct mlx5e_txqsq *sq)
> +{
> +	struct net_dim_sample dim_sample;

Likewise.

> +static inline void mlx5e_handle_rx_dim(struct mlx5e_rq *rq)
> +{

Likewise.