Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: alexey.kodanev@oracle.com
Cc: netdev@vger.kernel.org, edumazet@google.com, kafai@fb.com
Subject: Re: [PATCH net v5 2/3] ipv6: allow to cache dst for a connected sk in ip6_sk_dst_lookup_flow()
Date: Mon, 02 Apr 2018 11:17:42 -0400 (EDT)	[thread overview]
Message-ID: <20180402.111742.2147769696188522256.davem@davemloft.net> (raw)
In-Reply-To: <1522677635-5364-3-git-send-email-alexey.kodanev@oracle.com>

From: Alexey Kodanev <alexey.kodanev@oracle.com>
Date: Mon,  2 Apr 2018 17:00:34 +0300

> +++ b/net/ipv6/ip6_output.c
> @@ -1105,23 +1105,32 @@ struct dst_entry *ip6_dst_lookup_flow(const struct sock *sk, struct flowi6 *fl6,
>   *	@sk: socket which provides the dst cache and route info
>   *	@fl6: flow to lookup
>   *	@final_dst: final destination address for ipsec lookup
> + *	@connected: whether @sk is connected or not
 ...
>  struct dst_entry *ip6_sk_dst_lookup_flow(struct sock *sk, struct flowi6 *fl6,
> -					 const struct in6_addr *final_dst)
> +					 const struct in6_addr *final_dst,
> +					 int connected)

Please use type 'bool' and true/false for this new parameter.

Thank you.

  reply	other threads:[~2018-04-02 15:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-02 14:00 [PATCH net v5 0/3] ipv6: udp6: set dst cache for a connected sk if current not valid Alexey Kodanev
2018-04-02 14:00 ` [PATCH net v5 1/3] ipv6: add a wrapper for ip6_dst_store() with flowi6 checks Alexey Kodanev
2018-04-02 14:00 ` [PATCH net v5 2/3] ipv6: allow to cache dst for a connected sk in ip6_sk_dst_lookup_flow() Alexey Kodanev
2018-04-02 15:17   ` David Miller [this message]
2018-04-02 14:00 ` [PATCH net v5 3/3] ipv6: udp6: set dst cache for a connected sk if current not valid Alexey Kodanev
2018-04-05  1:34   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180402.111742.2147769696188522256.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alexey.kodanev@oracle.com \
    --cc=edumazet@google.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox