From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Biggers Subject: Re: [PATCH v2] KEYS: DNS: limit the length of option strings Date: Mon, 2 Apr 2018 12:20:35 -0700 Message-ID: <20180402192035.GC59810@gmail.com> References: <20180228190510.215801-1-ebiggers3@gmail.com> <31292.1520438077@warthog.procyon.org.uk> <20180312175707.GA230165@gmail.com> <20180323202122.GB16350@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: keyrings@vger.kernel.org, netdev@vger.kernel.org, Mark Rutland , Eric Biggers To: David Howells Return-path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:37936 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755276AbeDBTUh (ORCPT ); Mon, 2 Apr 2018 15:20:37 -0400 Content-Disposition: inline In-Reply-To: <20180323202122.GB16350@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Mar 23, 2018 at 01:21:22PM -0700, Eric Biggers wrote: > On Mon, Mar 12, 2018 at 10:57:07AM -0700, Eric Biggers wrote: > > On Wed, Mar 07, 2018 at 03:54:37PM +0000, David Howells wrote: > > > Eric Biggers wrote: > > > > > > > Fix it by limiting option strings (combined name + value) to a much more > > > > reasonable 128 bytes. The exact limit is arbitrary, but currently the > > > > only recognized option is formatted as "dnserror=%lu" which fits well > > > > within this limit. > > > > > > There will be more options coming ("ipv4", "ipv6") but they shouldn't overrun > > > this limit and we can always extend the limit if need be. > > > > > > David > > > > David (Howells) do you want to take this patch through the keyrings tree or > > should I ask David Miller to take it through net-next? > > > > Eric > > Ping. Ping again.