From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v15 ] net/veth/XDP: Line-rate packet forwarding in kernel Date: Tue, 03 Apr 2018 12:45:32 -0400 (EDT) Message-ID: <20180403.124532.1022029769048332125.davem@davemloft.net> References: <20180402181602.jpdb25ytmffg2gei@ast-mbp.dhcp.thefacebook.com> <9cb8a162-3b6a-abfa-4f6e-524995bbfb8d@gmail.com> <4f0c0f20-ce25-4996-4f28-14a73c988446@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dsahern@gmail.com, alexei.starovoitov@gmail.com, mislam4@kent.edu, netdev@vger.kernel.org, stephen@networkplumber.org, agaceph@gmail.com, xemul@openvz.org, edumazet@google.com, brouer@redhat.com To: john.fastabend@gmail.com Return-path: Received: from shards.monkeyblade.net ([184.105.139.130]:54196 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751496AbeDCQpe (ORCPT ); Tue, 3 Apr 2018 12:45:34 -0400 In-Reply-To: <4f0c0f20-ce25-4996-4f28-14a73c988446@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: John Fastabend Date: Tue, 3 Apr 2018 09:41:08 -0700 > On 04/03/2018 08:07 AM, David Ahern wrote: >> 4. What about other stacked devices - bonds and bridges - will those >> just work with the bpf helper? VRF is already handled of course. ;-) > > So if we simply handle this like other stacked devices and call the > lower devs xdp_xmit routine we should get reasonable behavior. For > bonds and bridges I guess some generalization is needed though because > everything at the moment is skb centric. I don't think its necessary > in the first series though. It can be added later. I wonder if we need some feature bit gating this passthrough, just like the various ->vlan_features and ->hw_enc_features.